Skip to content

Support for historical usernames with trailing hyphens. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support for historical usernames with trailing hyphens. #5

wants to merge 2 commits into from

Conversation

@En-En-Code
Copy link

@En-En-Code En-En-Code commented Jan 2, 2023

By switching to a negated look-ahead assertion, the new RegExp can easily detect double hyphens while also allowing a single hyphen at the end of a username. We don't lose the following character checked against [a-z\d] from the positive look-ahead assertion as this is covered by the earlier instance of this in the expression.

Added new unit test cases and updated README.md.

Resolves #4.

@En-En-Code
Support for historical accounts with trailing hyphens.
1c15708 
Also added new unit test cases to confirm proper behavior and updated README.md.
@En-En-Code
Fix README.md indent
da90603
@Rudxain
Copy link

Rudxain commented Jan 20, 2025

What if it was a 2nd regex? That way, consumers can choose between either or both

@En-En-Code
Copy link
Author

En-En-Code commented Jan 25, 2025

I agree that the library would be more useful if it provided both, considering validating an existing account's username and a potential new account's username are different needs and this change would break the latter.
Unfortunately, there are a few outstanding issues, such as how it exports the regex, the new issue #7 with additional edge cases, and the author's absense from the project. which prevent this update and subsequent merge.
If you need whichever regex, just copy it from either this project's or my fork's index.js. I don't use this project directly (a little copy-paste is more managable than a little dependency).

@Rudxain
Copy link

Rudxain commented Jan 25, 2025

I don't use this project directly

Me neither, lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Does not match trailing dash

2 participants

@En-En-Code @Rudxain